[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-m68k
Subject:    Re: [PATCH] lib/rbtree: avoid pointless rb_node alignment
From:       Andrew Morton <akpm () linux-foundation ! org>
Date:       2020-01-21 21:04:44
Message-ID: 20200121130444.0f5c39dc1ca6ba393084b14b () linux-foundation ! org
[Download RAW message or body]

On Mon, 20 Jan 2020 09:51:44 -0800 Davidlohr Bueso <dave@stgolabs.net> wrote:

> On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:
> 
> >timerqueue_del() uses rbtree, and
> >
> >    #define rb_parent(r)   ((struct rb_node *)((r)->__rb_parent_color & ~3))
> >
> >relies on all objects being 4-byte aligned.  But your patch broke that
> >assumption on m68k, where the default alignment is 2-byte.
> >
> >Andrew: please drop this patch.
> 
> Yeah that's too bad. I'll send a patch improving the comment around the alignment
> once the patch is dropped.

Thanks, I'll drop this patch.
[prev in list] [next in list] [prev in thread] [next in thread]