[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-m68k
Subject:    Re: [PATCH] m68k/atari - ide: do not register interrupt if host->get_lock is set
From:       Michael Schmitz <schmitzmic () gmail ! com>
Date:       2014-01-30 19:41:28
Message-ID: CAOmrzkJY-zGHfoX7zO+AXYgr0SRYHBohQJ5nD2X8BKogptUQoA () mail ! gmail ! com
[Download RAW message or body]

Geert,

On Fri, Jan 31, 2014 at 4:03 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, Jan 28, 2014 at 9:07 AM, Michael Schmitz <schmitzmic@gmail.com> wrote:
>> --- a/drivers/ide/ide-probe.c
>> +++ b/drivers/ide/ide-probe.c
>> @@ -853,8 +853,9 @@ static int init_irq (ide_hwif_t *hwif)
>>         if (irq_handler == NULL)
>>                 irq_handler = ide_intr;
>>
>> -       if (request_irq(hwif->irq, irq_handler, sa, hwif->name, hwif))
>> -               goto out_up;
>> +       if (!host->get_lock)
>> +               if (request_irq(hwif->irq, irq_handler, sa, hwif->name, hwif))
>> +                       goto out_up;
>
> Don't you need a similar check for free_irq()?

Absolutely. Thanks for spotting this. I'll send the fixed version to linux-ide.

Cheers,

  Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]