[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-m68k
Subject:    Re: [PATCH] macsonic/jazzsonic drivers update (part 2)
From:       Jeff Garzik <jgarzik () pobox ! com>
Date:       2005-08-20 4:50:17
Message-ID: 4306B689.6050705 () pobox ! com
[Download RAW message or body]

Finn Thain wrote:
> 
> On Wed, 13 Jul 2005, Finn Thain wrote:
> 
> 
>>On Sun, 26 Jun 2005, Jeff Garzik wrote:
>>
>>
>>>Patch looks OK to me.  Comments:
>>>
>>>1) Either Geert or Ralf can merge this, with my ACK.
>>>
>>>2) Would be nice to get it tested on the machines you list as untested.
>>>
>>>3) [possible problem in driver, not your changes] I wonder if IRQ_HANDLED is
>>>ever returned for shared interrupts?  I don't know enough about the platform
>>>interrupt architecture to answer this question.
>>>
>>>4) Remove casts to/from void.  This is especially noticable in all the casts
>>>of the netdev_priv() return value.
>>>
>>>5) If it doesn't cause too much patch noise, consider using enums rather than
>>>#defines, for numeric constants.  This gives the compiler more type
>>>information and makes the symbols visible in a debugger.  This is a
>>>-maintainer preference- issue overall, so don't sweat it if you disagree.
>>
>>
>>This patch removes the unecessary void* casts introduced in the first patch.
> 
> 
> Update:
> 
> The two patches referred to above have been tested on Jazz MIPS and
> ack'd off-list by Thomas Bogendorfer. He also added the cosmetic change below.
> 
> I think this is ready to be merged (Jeff?)
> 
> Roman, is your m68k DMA implementation ready for commit? Thomas will take 
> care of the Jazz one.

Can you please resend with full description and sign-off list?

i.e. rule #6 of

	http://linux.yyz.us/patch-format.html

Regards,

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]