[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-keyrings
Subject: Re: [PATCH] Revert "crypto: pkcs7 - remove sha1 support"
From: Herbert Xu <herbert () gondor ! apana ! org ! au>
Date: 2024-03-22 11:45:09
Message-ID: Zf1vRbvwYvj1KcTS () gondor ! apana ! org ! au
[Download RAW message or body]
On Wed, Mar 13, 2024 at 04:32:27PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> This reverts commit 16ab7cb5825fc3425c16ad2c6e53d827f382d7c6 because it
> broke iwd. iwd uses the KEYCTL_PKEY_* UAPIs via its dependency libell,
> and apparently it is relying on SHA-1 signature support. These UAPIs
> are fairly obscure, and their documentation does not mention which
> algorithms they support. iwd really should be using a properly
> supported userspace crypto library instead. Regardless, since something
> broke we have to revert the change.
>
> It may be possible that some parts of this commit can be reinstated
> without breaking iwd (e.g. probably the removal of MODULE_SIG_SHA1), but
> for now this just does a full revert to get things working again.
>
> Reported-by: Karel Balej <balejk@matfyz.cz>
> Closes: https://lore.kernel.org/r/CZSHRUIJ4RKL.34T4EASV5DNJM@matfyz.cz
> Cc: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> crypto/asymmetric_keys/mscode_parser.c | 3 +
> crypto/asymmetric_keys/pkcs7_parser.c | 4 ++
> crypto/asymmetric_keys/public_key.c | 3 +-
> crypto/asymmetric_keys/signature.c | 2 +-
> crypto/asymmetric_keys/x509_cert_parser.c | 8 +++
> crypto/testmgr.h | 80 +++++++++++++++++++++++
> include/linux/oid_registry.h | 4 ++
> kernel/module/Kconfig | 5 ++
> 8 files changed, 107 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic