[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-keyrings
Subject:    Re: [PATCH v0 1/8] hw-bound-key: introducing the generic structure
From:       Jarkko Sakkinen <jarkko () kernel ! org>
Date:       2022-10-12 8:53:37
Message-ID: Y0aAkQBDN0Pn0sKX () kernel ! org
[Download RAW message or body]

On Thu, Oct 06, 2022 at 06:38:30PM +0530, Pankaj Gupta wrote:
> +#define set_hbk_info(hbk_info, hw_flags, key_len) do {\
> +	hbk_info->flags = hw_flags;\
> +	hbk_info->key_sz = key_len;\
> +} while (0)

Also this:

1. Undocumented.
2. No idea why you want to use a macro instead of inline function.

BR, Jarkko
[prev in list] [next in list] [prev in thread] [next in thread]