[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-keyrings
Subject:    Re: [PATCH v2] KEYS: fix memory leaks when reading certificate
From:       David Howells <dhowells () redhat ! com>
Date:       2022-03-30 15:37:14
Message-ID: 2996113.1648654634 () warthog ! procyon ! org ! uk
[Download RAW message or body]

Denis Glazkov <d.glazkov@omp.ru> wrote:

> The `exit()` function usage produce possible memory leaks. This
> patch removes the use of the `exit()` function and adds memory
> free in case of a negative scenarios.

?

Barring a kernel bug, there should be no memory leaks from exit().  _exit() is
the ultimate process cleanup tool.  Calling free() won't necessarily return
the memory allocated by malloc() to the kernel.

Unless you have a good reason to actually tear down everything, just print a
message and call exit on error in little helpers like this.

David

[prev in list] [next in list] [prev in thread] [next in thread]