[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-keyrings
Subject:    Re: [PATCH RESEND 1/1] keys: Allow access to key_type_lookup()/key_type_put() within kernel.
From:       Jarkko Sakkinen <jarkko () kernel ! org>
Date:       2022-02-21 20:28:16
Message-ID: YhP14Flme60pk7Pu () iki ! fi
[Download RAW message or body]

On Mon, Feb 21, 2022 at 09:27:57PM +0100, Jarkko Sakkinen wrote:
> On Mon, Feb 21, 2022 at 08:44:24AM -0600, Douglas Miller wrote:
> > Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com>
> > ---
> >  include/linux/key-type.h | 2 ++
> >  security/keys/key.c      | 2 ++
> >  2 files changed, 4 insertions(+)
> > 
> > diff --git a/include/linux/key-type.h b/include/linux/key-type.h
> > index 7d985a1dfe4a..868a6fb368f3 100644
> > --- a/include/linux/key-type.h
> > +++ b/include/linux/key-type.h
> > @@ -165,6 +165,8 @@ extern struct key_type key_type_keyring;
> >  
> >  extern int register_key_type(struct key_type *ktype);
> >  extern void unregister_key_type(struct key_type *ktype);
> > +extern struct key_type *key_type_lookup(const char *type);
> > +extern void key_type_put(struct key_type *ktype);
> >  
> >  extern int key_payload_reserve(struct key *key, size_t datalen);
> >  extern int key_instantiate_and_link(struct key *key,
> > diff --git a/security/keys/key.c b/security/keys/key.c
> > index c45afdd1dfbb..3091fd6d65a7 100644
> > --- a/security/keys/key.c
> > +++ b/security/keys/key.c
> > @@ -719,6 +719,7 @@ struct key_type *key_type_lookup(const char *type)
> >  found_kernel_type:
> >  	return ktype;
> >  }
> > +EXPORT_SYMBOL(key_type_lookup);
> >  
> >  void key_set_timeout(struct key *key, unsigned timeout)
> >  {
> > @@ -744,6 +745,7 @@ void key_type_put(struct key_type *ktype)
> >  {
> >  	up_read(&key_types_sem);
> >  }
> > +EXPORT_SYMBOL(key_type_put);
> >  
> >  /*
> >   * Attempt to update an existing key.
> > -- 
> > 2.27.0
> > 
> 
> This should be included with the changes that actually require this.

I.e. planned changes do not count.

BR, Jarkko
[prev in list] [next in list] [prev in thread] [next in thread]