[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-keyrings
Subject:    Re: [PATCH] keys: Do not check the retval of commit_creds in join_session_keyring
From:       Jarkko Sakkinen <jarkko.sakkinen () linux ! intel ! com>
Date:       2020-08-17 21:17:37
Message-ID: 20200817211737.GC44714 () linux ! intel ! com
[Download RAW message or body]

On Tue, Jul 28, 2020 at 01:06:35PM +0200, Marcus Hüwe wrote:
> On 2020-06-17 04:46:24 +0300, Jarkko Sakkinen wrote:
> > On Fri, Jun 12, 2020 at 01:25:33PM +0200, Marcus Huewe wrote:
> > > Do not check the return value of the commit_creds call in
> > > join_session_keyring in order to make the code more concise.
> > > Since commit_creds always returns 0, the if-statement is not needed
> > > and the session keyring's serial can be directly assigned to the
> > > "ret" variable.
> > >
> > > Signed-off-by: Marcus Huewe <suse-tux@gmx.de>
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > David, can you pick this up to your tree (give that a generic
> > keyring change)?
> >
> Just a gentle ping - any news on this?:)
> 
> (I'm perfectly fine if you don't want to take it... (since it is
> just a minor cleanup and no bugfix))
> 
> 
> Marcus

I just came from two weeks of vacation and one week of network
connectivity issues (could not connect to the company VPN).

I still think that David should at least ack this.

/Jarkko
[prev in list] [next in list] [prev in thread] [next in thread]