[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-keyrings
Subject:    Re: [PATCH] KEYS: trusted: fix type warnings in ntohl/nthos
From:       Jarkko Sakkinen <jarkko.sakkinen () linux ! intel ! com>
Date:       2019-12-18 22:06:14
Message-ID: 73018a43cf345264d135e4b3a4c6c84ba0651489.camel () linux ! intel ! com
[Download RAW message or body]

On Tue, 2019-12-17 at 11:09 +0000, Ben Dooks (Codethink) wrote:
> The ntohl takes a __be32 and ntohs takes __be16, so cast to
> those types before passing it to the byte swapping functions.
> 
> Note, would be32_to_cpu and be16_to_cpu be better here?

Yes, can you refine this?

Also in commit message you could

"
E.g.

security/keys/trusted-keys/trusted_tpm1.c:201:19: warning: cast to restricted __be32
"

We get the idea from one line :-)

/Jarkko

[prev in list] [next in list] [prev in thread] [next in thread]