[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] Fix queued SIGIO
From:       "Robert H. de Vries" <rhdv () rhdv ! cistron ! nl>
Date:       2000-09-19 18:12:29
[Download RAW message or body]

On Mon, 18 Sep 2000, Alan Cox wrote:
>> The problem is really that SI_SIGIO is negative, but it should be positive
>> to make SI_FROMUSER return false on it.
>>
>> Changing it would unfortunately break binary compatibility. This patch
>

It would be better to change SI_SIGIO in all the 
include/asm-*/siginfo.h files from -5 to __SI_CODE(__SI_SIGIO, -5)
__SI_SIGIO would become (6 << 16).
The code in arch/*/kernel/signal.c only copies the lower 16 bits to user 
space. This means that the test SI_FROMKERNEL returns true and user space 
still gets the same values as before.

The same trick is indeed used also in my POSIX timer patch.

	Robert

-- 
Robert de Vries
rhdv@rhdv.cistron.nl
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]