[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] Remove extra shift in __SI_CODE macro
From:       Linus Torvalds <torvalds () transmeta ! com>
Date:       2000-07-23 18:38:51
[Download RAW message or body]



On Sun, 23 Jul 2000, Robert H. de Vries wrote:
> 
> The __SI_CODE macro shifts its argument 16 bits to the left while the only 
> argument used is already shifted 16 bits to the left. In this way no bits are 
> left on a 32 bit architecture.
> Hence this patch, which removes the superfluous shift.

Sounds like the _users_ of __SI_CODE should be fixed, rather than
__SI_CODE. The new definition of __SI_CODE doesn't make much sense, in my
opinion.

		Linus


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]