[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: memory leak in sr_ioctl.c in Linux 2.2.12/13
From:       Martin Vogt <mvogt () rhrk ! uni-kl ! de>
Date:       1999-12-07 13:29:27
[Download RAW message or body]

On Mon, Dec 06, 1999 at 05:57:04PM +0000, Alan Cox wrote:
> > -        if (lba < 0 || lba >= scsi_CDs[target].capacity)
> > +
> > +        if (lba < 0 || lba >= scsi_CDs[target].capacity) {
> > +	    scsi_free(raw);
> >              return -EINVAL;
> > +	}
> 
> Snap 8). Already done the same fix. That one is indeed nasty.

In the original source the scsi_free(raw) call ist protected
with a spinlock/spinunlock. But I donīt know if its necessary
here as well.

regards,

Martin


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]