[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] 2.3.18: siginfo data available for all signals
From:       Robert de Vries <rhdv () rhdv ! cistron ! nl>
Date:       1999-09-15 20:53:21
[Download RAW message or body]

On Wed, 15 Sep 1999, Jamie Lokier wrote:

> Robert H. de Vries wrote:
> > The last few times I have sent in this patch I have received zero
> > reactions. On the other hand the patch does not seem to make it into
> > kernels. Something must be wrong, however I don't know what it is.
> 
> Did you miss Linus' announcement?  He is on holiday for 2 weeks starting
> a couple of days ago.  Patches will be discarded during that time.
Nope I didn't, that is why I sent the patch not to Linus but to Alan. (I
agree that this is a very subtle hint :-).

> 
> > This patch handles all signals alike. Every signal is put into the signal
> > queue. Only real-time signals are queued multiple times. Other signals can
> > have only one siginfo in the queue.
> > 
> > The patch also fixes some unitialized data being passed to user space
> > under some circumstances. When sending a signal using kill, the siginfo
> > structure on the stack was not zeroed.
> 
> In principle I approve, as long as it does not slow signal delivery.  It
> was obviously intended to work this way all along.  Sorry I haven't time
> to examine the code.

This all depends on the speed of the slab allocator for the siginfo
structure and the initialisation of the structure. I guess that it's fast
because that was the reason for putting in the allocator in the first
place and making a special slab for the siginfo structures.

	Robert

-- 
Robert de Vries
rhdv@rhdv.cistron.nl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]