[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Automating basic patch tests...
From:       Riley Williams <rhw () bigfoot ! com>
Date:       1998-09-30 20:59:19
[Download RAW message or body]

Hi there.

===8<=== CUT ===>8=== (Subject was "Re: Jitterbug")

 > JitterBug could also test new patches in some way or another (at
 > the least it could see if with the new patch the kernel would
 > compile), and then send a reply to the submitter if it fails with
 > an explanation as to why. Admittedly this will cause the machine
 > hosting this to be rather busy if alot of patches come in, but it
 > would be a usefull test.. 

As a very basic minimum, I'd like to suggest that it perform the
following tests:

 1. The submitted patch applies cleanly to the current kernel,
    else it is automatically rejected. As I see it, there's little
    point putting patches into the system if one has to use an old
    kernel to apply them to, or if they can only be applied against
    some semi-mangled kernel in the first place.

    Yes, I have seen patches posted that just don't apply cleanly
    to the current stable kernel when they claim to...and both of
    the above reasons have occurred...

 2. Does the patch only modify documentation files? If so, then
    it probably doesn't need to go to Linus at all, but to somebody
    who has taken responsibility for the documentation and thus
    relieved Linus of the headache of worrying about that.

    Incidentally, if this suggestion is taken up, the person made
    responsible for the documentation needs to be agreed by ALL
    of the current admin, otherwise it just won't work...and since
    I'm basically an unknown to the Linux admin, there's no point
    in my volunteering for the job, much as I'd like to.

 3. How many different files does the patch modify? Should there
    be a limit on this number, to discourage submission of patches
    that change too much at once? In my opinion, it's easier to
    evaluate a patch that only patches one file than one that
    modifies a dozen unrelated files.

 4. (As an alternative to 3) How many different directories does
    the patch modify files in? If a patch is limited to files in
    a single directory, or in two directories that share a
    parent-child relationship, it probably only patches a single
    subsystem of the Linux kernel.

As I see things, any tests for compilability should only be applied
AFTER all of the above tests have been passed.

Comments, anybody?

Best wishes from Riley.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]