[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: AX.25, bpq, and 2.1.8x
From:       Jason Duerstock <jasond () cdc ! net>
Date:       1998-02-28 17:34:27
[Download RAW message or body]

On Sat, 28 Feb 1998, A.N.Kuznetsov wrote:

> In article <Pine.BSF.3.96.980227162622.15554B-100000@shell.cdc.net> you wrote:
> : 1) The original kernel oops is in __neigh_event_send in
> : net/core/neighbour.c. When the function tries to call the
> : neigh->ops->solicit() routine, the value for neigh->ops->solicit is NULL.
> 
> Oi! Yes, this branch was never tested :-)
> Please fix these lines in net/ipv4/arp.c:
> 
> #if defined(CONFIG_AX25) || defined(CONFIG_AX25)
> static struct neigh_ops arp_broken_ops =
> {
> 	AF_INET,
> 	NULL,
> -	NULL,
> -	NULL,
> +	arp_solicit,
> +	arp_error_report,
> 	neigh_compat_output,
> 	neigh_compat_output,
> -	neigh_compat_output,
> -	neigh_compat_output,
> +	ip_acct_output,
> +	ip_acct_output,
> };
> #endif

At least on minimal testing, it seems to work.  I'll have to do some more
kernel recompilation legwork to put it through more strenuous tests.

Jason


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic