From linux-kernel  Thu Apr 25 10:05:20 2024
From: Helge Deller <deller () gmx ! de>
Date: Thu, 25 Apr 2024 10:05:20 +0000
To: linux-kernel
Subject: Re: [PATCH -next] fbdev: savage: Handle err return when savagefb_check_var failed
Message-Id: <1a3d30bc-130c-49ce-93ed-d380d5159dfa () gmx ! de>
X-MARC-Message: https://marc.info/?l=linux-kernel&m=171403949209655

On 4/16/24 08:51, Cai Xinchen wrote:
> The commit 04e5eac8f3ab("fbdev: savage: Error out if pixclock equals zer=
o")
> checks the value of pixclock to avoid divide-by-zero error. However
> the function savagefb_probe doesn't handle the error return of
> savagefb_check_var. When pixclock is 0, it will cause divide-by-zero err=
or.
>
> Fixes: 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero")
> Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
> Cc: stable@vger.kernel.org
> ---
>   drivers/video/fbdev/savage/savagefb_driver.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)

applied.
Thanks!
Helge



>
> diff --git a/drivers/video/fbdev/savage/savagefb_driver.c b/drivers/vide=
o/fbdev/savage/savagefb_driver.c
> index ebc9aeffdde7..ac41f8f37589 100644
> --- a/drivers/video/fbdev/savage/savagefb_driver.c
> +++ b/drivers/video/fbdev/savage/savagefb_driver.c
> @@ -2276,7 +2276,10 @@ static int savagefb_probe(struct pci_dev *dev, co=
nst struct pci_device_id *id)
>   	if (info->var.xres_virtual > 0x1000)
>   		info->var.xres_virtual =3D 0x1000;
>   #endif
> -	savagefb_check_var(&info->var, info);
> +	err =3D savagefb_check_var(&info->var, info);
> +	if (err)
> +		goto failed;
> +
>   	savagefb_set_fix(info);
>
>   	/*