From linux-kernel Wed Apr 10 13:24:57 2024 From: Helge Deller Date: Wed, 10 Apr 2024 13:24:57 +0000 To: linux-kernel Subject: Re: [PATCH v2 1/1] fbdev: add HAS_IOPORT dependencies Message-Id: X-MARC-Message: https://marc.info/?l=linux-kernel&m=171275549523842 On 4/10/24 12:56, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=3Dn will disable inb()/outb() and friends a= t > compile time. We thus need to add HAS_IOPORT as dependency for those > drivers using them. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle added to fbdev git tree. Thanks! Helge > --- > Note: This patch does not depend any not-yet-mainline HAS_IOPORT changes > and may be merged via subsystem specific trees at your earliest > convenience. > > v1 -> v2: > - Add dependency for FB_ARC > > drivers/video/fbdev/Kconfig | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 197b6d5268e9..76bbfd3767da 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -157,7 +157,7 @@ config FB_IMX > > config FB_CYBER2000 > tristate "CyberPro 2000/2010/5000 support" > - depends on FB && PCI && (BROKEN || !SPARC64) > + depends on FB && PCI && HAS_IOPORT && (BROKEN || !SPARC64) > select FB_IOMEM_HELPERS > help > This enables support for the Integraphics CyberPro 20x0 and 5000 > @@ -245,7 +245,7 @@ config FB_FM2 > > config FB_ARC > tristate "Arc Monochrome LCD board support" > - depends on FB && (X86 || COMPILE_TEST) > + depends on FB && HAS_IOPORT && (X86 || COMPILE_TEST) > select FB_SYSMEM_HELPERS_DEFERRED > help > This enables support for the Arc Monochrome LCD board. The board > @@ -1046,7 +1046,7 @@ config FB_ATY_BACKLIGHT > > config FB_S3 > tristate "S3 Trio/Virge support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1107,7 +1107,7 @@ config FB_SAVAGE_ACCEL > > config FB_SIS > tristate "SiS/XGI display support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select BOOT_VESA_SUPPORT if FB_SIS =3D y > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > @@ -1138,7 +1138,7 @@ config FB_SIS_315 > > config FB_VIA > tristate "VIA UniChrome (Pro) and Chrome9 display support" > - depends on FB && PCI && GPIOLIB && I2C && (X86 || COMPILE_TEST) > + depends on FB && PCI && GPIOLIB && I2C && HAS_IOPORT && (X86 || COMPIL= E_TEST) > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1177,7 +1177,7 @@ endif > > config FB_NEOMAGIC > tristate "NeoMagic display support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1204,7 +1204,7 @@ config FB_KYRO > > config FB_3DFX > tristate "3Dfx Banshee/Voodoo3/Voodoo5 display support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1252,7 +1252,7 @@ config FB_VOODOO1 > > config FB_VT8623 > tristate "VIA VT8623 support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1267,7 +1267,7 @@ config FB_VT8623 > > config FB_TRIDENT > tristate "Trident/CyberXXX/CyberBlade support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1290,7 +1290,7 @@ config FB_TRIDENT > > config FB_ARK > tristate "ARK 2000PV support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > @@ -1814,7 +1814,7 @@ config FB_SSD1307 > > config FB_SM712 > tristate "Silicon Motion SM712 framebuffer support" > - depends on FB && PCI > + depends on FB && PCI && HAS_IOPORT > select FB_IOMEM_HELPERS > help > Frame buffer driver for the Silicon Motion SM710, SM712, SM721