[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH v2 2/6] twl-core: add power off implementation for twl603x
From:       Andreas Kemnade <andreas () kemnade ! info>
Date:       2023-12-03 21:16:05
Message-ID: 20231203221605.38496a8d () aktux
[Download RAW message or body]

On Fri, 1 Dec 2023 10:48:20 +0000
Lee Jones <lee@kernel.org> wrote:

> > +	if (err) {
> > +		pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);  
> 
> It would save an awful lot of lines and space if we could place these
> warnings/errors inside twl_i2c_read_u8().

Well, it is already in twl_i2c_read() ...
yes, we can save quite some lines.

Regards,
Andreas
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic