[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    RE: [PATCH v5 2/8] x86/resctrl: Prepare for different scope for control/monitor operations
From:       "Luck, Tony" <tony.luck () intel ! com>
Date:       2023-09-26 17:45:50
Message-ID: SJ1PR11MB608392F4682FE9EA0EC618C8FCC3A () SJ1PR11MB6083 ! namprd11 ! prod ! outlook ! com
[Download RAW message or body]

>> Create separate domain lists for control and monitor operations.
>> 
>> No important functional change. But note that errors during
>
> Its better to remove the line "No important functional change."

Will drop it.

>>  	struct list_head	domains;
>> +	struct list_head	mondomains;
>
> For consistancy, its better to rename it to mon_domains(to be inline with
> mon_scope, mon_capable).

Again, you are thinking like Reinette! You'll be a resctrl maintainer soon.

>> +struct rdt_domain *rdt_find_ctrldomain(struct list_head *h, int id,
>> +				       struct list_head **pos);
>> +struct rdt_domain *rdt_find_mondomain(struct list_head *h, int id,
>> +				      struct list_head **pos);
>
> For consistancy, it is better to rename to rdt_find_ctrl_domain and
> rdt_find_mon_domain respectively.

Agreed.

Thanks for the review.

-Tony

[prev in list] [next in list] [prev in thread] [next in thread]