[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH v3 16/19] x86/resctrl: Add cpu online callback for resctrl work
From:       Reinette Chatre <reinette.chatre () intel ! com>
Date:       2023-03-31 23:29:43
Message-ID: c429e614-fe97-1c44-287a-9c52438dbeb2 () intel ! com
[Download RAW message or body]

Hi James,

On 3/20/2023 10:26 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 351319403f84..8e25ea49372e 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -603,19 +603,20 @@ static void clear_closid_rmid(int cpu)
>  	wrmsr(MSR_IA32_PQR_ASSOC, RESCTRL_RESERVED_CLOSID, 0);
>  }
>  
> -static int resctrl_online_cpu(unsigned int cpu)
> +static int resctrl_arch_online_cpu(unsigned int cpu)
>  {
>  	struct rdt_resource *r;
> +	int err;

Could you please rename err to ret? 

Reinette
[prev in list] [next in list] [prev in thread] [next in thread]