[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] [v2] at86rf230: convert to gpio descriptors
From:       Dmitry Torokhov <dmitry.torokhov () gmail ! com>
Date:       2023-01-31 23:52:55
Message-ID: CAKdAkRQT_Jk5yBeMZqh=M1JscVLFieZTQjLGOGxy8nHh8SnD3A () mail ! gmail ! com
[Download RAW message or body]

Hi Arnd,

On Thu, Jan 26, 2023 at 8:32 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
>         /* Reset */
> -       if (gpio_is_valid(rstn)) {
> +       if (rstn) {
>                 udelay(1);
> -               gpio_set_value_cansleep(rstn, 0);
> +               gpiod_set_value_cansleep(rstn, 0);
>                 udelay(1);
> -               gpio_set_value_cansleep(rstn, 1);
> +               gpiod_set_value_cansleep(rstn, 1);

For gpiod conversions, if we are not willing to chase whether existing
DTSes specify polarities
properly and create workarounds in case they are wrong, we should use
gpiod_set_raw_value*()
(my preference would be to do the work and not use "raw" variants).

In this particular case, arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
defines reset line as active low,
so you are leaving the device in reset state.

Please review your other conversion patches.

-- 
Dmitry
[prev in list] [next in list] [prev in thread] [next in thread]