[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH 1/3] mm: hugetlb_vmemmap: cleanup hugetlb_vmemmap related functions
From:       Mike Kravetz <mike.kravetz () oracle ! com>
Date:       2022-05-31 23:58:23
Message-ID: 09b60548-0495-5365-2bf7-97cc597100ac () oracle ! com
[Download RAW message or body]

On 5/31/22 16:47, Mike Kravetz wrote:
> On 4/4/22 00:46, Muchun Song wrote:
> > The word of "free" is not expressive enough to express the feature of optimizing
> > vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> > And some function names are prefixed with "huge_page" instead of "hugetlb", it is
> > easily to be confused with THP.  In this patch , cheanup related functions to make
> > code more clear and expressive.
> 
> Some typos in the commit message.  Might be better as:
> 
> The keyword "free" is not expressive enough to describe the feature of optimizing vmemmap pages \
> associated with each HugeTLB page.  Rename the keyword to "optimize".
> 
> Some function names are prefixed with "huge_page" instead of "hugetlb".  These can easily be confused \
> with THP.  Change function names to make code more clear and expressive.
> 

Sorry for the long lines :(

-- 
Mike Kravetz


[prev in list] [next in list] [prev in thread] [next in thread]