[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: fs/xfs/xfs_trans.c:559:8: warning: variable 'error' set but not used
From: kernel test robot <lkp () intel ! com>
Date: 2021-12-31 19:40:54
Message-ID: 202201010354.K9eHFohw-lkp () intel ! com
[Download RAW message or body]
Hi Dave,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4f3d93c6eaff6b84e43b63e0d7a119c5920e1020
commit: dc3ffbb14060c943469d5e12900db3a60bc3fa64 xfs: gut error handling in \
xfs_trans_unreserve_and_mod_sb()
date: 1 year, 7 months ago
config: x86_64-randconfig-a015-20211118 \
(https://download.01.org/0day-ci/archive/20220101/202201010354.K9eHFohw-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dc3ffbb14060c943469d5e12900db3a60bc3fa64
git remote add linus \
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch \
--no-tags linus master git checkout dc3ffbb14060c943469d5e12900db3a60bc3fa64
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/xfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
fs/xfs/xfs_trans.c: In function 'xfs_trans_unreserve_and_mod_sb':
> > fs/xfs/xfs_trans.c:559:8: warning: variable 'error' set but not used \
> > [-Wunused-but-set-variable]
559 | int error;
| ^~~~~
vim +/error +559 fs/xfs/xfs_trans.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 536
^1da177e4c3f41 Linus Torvalds 2005-04-16 537 /*
dc3ffbb14060c9 Dave Chinner 2020-05-20 538 * xfs_trans_unreserve_and_mod_sb() \
is called to release unused reservations and dc3ffbb14060c9 Dave Chinner \
2020-05-20 539 * apply superblock counter changes to the in-core superblock. The \
45c34141126a89 David Chinner 2007-06-18 540 * t_res_fdblocks_delta and \
t_res_frextents_delta fields are explicitly NOT 45c34141126a89 David Chinner \
2007-06-18 541 * applied to the in-core superblock. The idea is that that has \
already been 45c34141126a89 David Chinner 2007-06-18 542 * done.
^1da177e4c3f41 Linus Torvalds 2005-04-16 543 *
45c34141126a89 David Chinner 2007-06-18 544 * If we are not logging superblock \
counters, then the inode allocated/free and 45c34141126a89 David Chinner \
2007-06-18 545 * used block counts are not updated in the on disk superblock. In \
this case, 45c34141126a89 David Chinner 2007-06-18 546 * XFS_TRANS_SB_DIRTY \
will not be set when the transaction is updated but we 45c34141126a89 David Chinner \
2007-06-18 547 * still need to update the incore superblock with the changes. \
^1da177e4c3f41 Linus Torvalds 2005-04-16 548 */ 71e330b593905e Dave Chinner \
2010-05-21 549 void ^1da177e4c3f41 Linus Torvalds 2005-04-16 550 \
xfs_trans_unreserve_and_mod_sb( 0bd5ddedccca44 Dave Chinner 2015-02-23 551 \
struct xfs_trans *tp) ^1da177e4c3f41 Linus Torvalds 2005-04-16 552 {
0bd5ddedccca44 Dave Chinner 2015-02-23 553 struct xfs_mount *mp = \
tp->t_mountp; 0d485ada404b36 Dave Chinner 2015-02-23 554 bool rsvd = \
(tp->t_flags & XFS_TRANS_RESERVE) != 0; 45c34141126a89 David Chinner 2007-06-18 \
555 int64_t blkdelta = 0; 45c34141126a89 David Chinner 2007-06-18 556 \
int64_t rtxdelta = 0; 1b0407125f9a5b Christoph Hellwig 2010-09-30 557 \
int64_t idelta = 0; 1b0407125f9a5b Christoph Hellwig 2010-09-30 558 \
int64_t ifreedelta = 0; 0bd5ddedccca44 Dave Chinner 2015-02-23 @559 \
int error; ^1da177e4c3f41 Linus Torvalds 2005-04-16 560
1b0407125f9a5b Christoph Hellwig 2010-09-30 561 /* calculate deltas */
45c34141126a89 David Chinner 2007-06-18 562 if (tp->t_blk_res > 0)
45c34141126a89 David Chinner 2007-06-18 563 blkdelta = tp->t_blk_res;
45c34141126a89 David Chinner 2007-06-18 564 if ((tp->t_fdblocks_delta != 0) &&
45c34141126a89 David Chinner 2007-06-18 565 \
(xfs_sb_version_haslazysbcount(&mp->m_sb) || 45c34141126a89 David Chinner \
2007-06-18 566 (tp->t_flags & XFS_TRANS_SB_DIRTY))) 45c34141126a89 David \
Chinner 2007-06-18 567 blkdelta += tp->t_fdblocks_delta; \
45c34141126a89 David Chinner 2007-06-18 568 45c34141126a89 David Chinner \
2007-06-18 569 if (tp->t_rtx_res > 0) 45c34141126a89 David Chinner 2007-06-18 \
570 rtxdelta = tp->t_rtx_res; 45c34141126a89 David Chinner 2007-06-18 571 \
if ((tp->t_frextents_delta != 0) && 45c34141126a89 David Chinner 2007-06-18 572 \
(tp->t_flags & XFS_TRANS_SB_DIRTY)) 45c34141126a89 David Chinner 2007-06-18 573 \
rtxdelta += tp->t_frextents_delta; 45c34141126a89 David Chinner 2007-06-18 574
1b0407125f9a5b Christoph Hellwig 2010-09-30 575 if \
(xfs_sb_version_haslazysbcount(&mp->m_sb) || 1b0407125f9a5b Christoph Hellwig \
2010-09-30 576 (tp->t_flags & XFS_TRANS_SB_DIRTY)) { 1b0407125f9a5b Christoph \
Hellwig 2010-09-30 577 idelta = tp->t_icount_delta; 1b0407125f9a5b Christoph \
Hellwig 2010-09-30 578 ifreedelta = tp->t_ifree_delta; ^1da177e4c3f41 Linus \
Torvalds 2005-04-16 579 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 580
1b0407125f9a5b Christoph Hellwig 2010-09-30 581 /* apply the per-cpu counters */
1b0407125f9a5b Christoph Hellwig 2010-09-30 582 if (blkdelta) {
0d485ada404b36 Dave Chinner 2015-02-23 583 error = xfs_mod_fdblocks(mp, \
blkdelta, rsvd); dc3ffbb14060c9 Dave Chinner 2020-05-20 584 ASSERT(!error);
1b0407125f9a5b Christoph Hellwig 2010-09-30 585 }
45c34141126a89 David Chinner 2007-06-18 586
1b0407125f9a5b Christoph Hellwig 2010-09-30 587 if (idelta) {
501ab323875339 Dave Chinner 2015-02-23 588 error = xfs_mod_icount(mp, \
idelta); dc3ffbb14060c9 Dave Chinner 2020-05-20 589 ASSERT(!error);
^1da177e4c3f41 Linus Torvalds 2005-04-16 590 }
1b0407125f9a5b Christoph Hellwig 2010-09-30 591
1b0407125f9a5b Christoph Hellwig 2010-09-30 592 if (ifreedelta) {
e88b64ea1f3da6 Dave Chinner 2015-02-23 593 error = xfs_mod_ifree(mp, \
ifreedelta); dc3ffbb14060c9 Dave Chinner 2020-05-20 594 ASSERT(!error);
^1da177e4c3f41 Linus Torvalds 2005-04-16 595 }
1b0407125f9a5b Christoph Hellwig 2010-09-30 596
0bd5ddedccca44 Dave Chinner 2015-02-23 597 if (rtxdelta == 0 && !(tp->t_flags \
& XFS_TRANS_SB_DIRTY)) 0bd5ddedccca44 Dave Chinner 2015-02-23 598 return;
0bd5ddedccca44 Dave Chinner 2015-02-23 599
1b0407125f9a5b Christoph Hellwig 2010-09-30 600 /* apply remaining deltas */
0bd5ddedccca44 Dave Chinner 2015-02-23 601 spin_lock(&mp->m_sb_lock);
dc3ffbb14060c9 Dave Chinner 2020-05-20 602 mp->m_sb.sb_frextents += rtxdelta;
dc3ffbb14060c9 Dave Chinner 2020-05-20 603 mp->m_sb.sb_dblocks += \
tp->t_dblocks_delta; dc3ffbb14060c9 Dave Chinner 2020-05-20 604 \
mp->m_sb.sb_agcount += tp->t_agcount_delta; dc3ffbb14060c9 Dave Chinner \
2020-05-20 605 mp->m_sb.sb_imax_pct += tp->t_imaxpct_delta; dc3ffbb14060c9 Dave \
Chinner 2020-05-20 606 mp->m_sb.sb_rextsize += tp->t_rextsize_delta; \
dc3ffbb14060c9 Dave Chinner 2020-05-20 607 mp->m_sb.sb_rbmblocks += \
tp->t_rbmblocks_delta; dc3ffbb14060c9 Dave Chinner 2020-05-20 608 \
mp->m_sb.sb_rblocks += tp->t_rblocks_delta; dc3ffbb14060c9 Dave Chinner \
2020-05-20 609 mp->m_sb.sb_rextents += tp->t_rextents_delta; dc3ffbb14060c9 Dave \
Chinner 2020-05-20 610 mp->m_sb.sb_rextslog += tp->t_rextslog_delta; \
0bd5ddedccca44 Dave Chinner 2015-02-23 611 spin_unlock(&mp->m_sb_lock); \
1b0407125f9a5b Christoph Hellwig 2010-09-30 612 dc3ffbb14060c9 Dave Chinner \
2020-05-20 613 /* dc3ffbb14060c9 Dave Chinner 2020-05-20 614 * Debug \
checks outside of the spinlock so they don't lock up the dc3ffbb14060c9 Dave Chinner \
2020-05-20 615 * machine if they fail. dc3ffbb14060c9 Dave Chinner \
2020-05-20 616 */ dc3ffbb14060c9 Dave Chinner 2020-05-20 617 \
ASSERT(mp->m_sb.sb_imax_pct >= 0); dc3ffbb14060c9 Dave Chinner 2020-05-20 618 \
ASSERT(mp->m_sb.sb_rextslog >= 0); 1b0407125f9a5b Christoph Hellwig 2010-09-30 619 \
return; ^1da177e4c3f41 Linus Torvalds 2005-04-16 620 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 621
> > > > > > The code at line 559 was first introduced by commit
> > > > > > 0bd5ddedccca4451ac2390d1155b4ab74b990eff xfs: replace \
> > > > > > xfs_mod_incore_sb_batched
> > > > > > TO: Dave Chinner <dchinner@redhat.com>
> > > > > > CC: Dave Chinner <david@fromorbit.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic