Just a remark: the function fuel_gauge_reg_readb() is reporting via dev_err(). But some callers are reporting also. Maybe someone should take a look. The valid return seems >=3D0 so removing the dev_err seems an option. jm2c, re, wh ________________________________________ Von: Colin King Gesendet: Freitag, 18. Juni 2021 11:29:24 An: Sebastian Reichel; Hans de Goede; Chen-Yu Tsai; linux-pm@vger.kernel.or= g Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Betreff: [PATCH] power: supply: axp288_fuel_gauge: remove redundant continu= e statement WARNUNG: Diese E-Mail kam von au=DFerhalb der Organisation. Klicken Sie nic= ht auf Links oder =F6ffnen Sie keine Anh=E4nge, es sei denn, Sie kennen den= /die Absender*in und wissen, dass der Inhalt sicher ist. From: Colin Ian King The continue statement at the end of a for-loop has no effect, invert the if expression and remove the continue. Signed-off-by: Colin Ian King --- drivers/power/supply/axp288_fuel_gauge.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/suppl= y/axp288_fuel_gauge.c index 39e16ecb7638..20e63609ab47 100644 --- a/drivers/power/supply/axp288_fuel_gauge.c +++ b/drivers/power/supply/axp288_fuel_gauge.c @@ -142,9 +142,7 @@ static int fuel_gauge_reg_readb(struct axp288_fg_info *= info, int reg) for (i =3D 0; i < NR_RETRY_CNT; i++) { ret =3D regmap_read(info->regmap, reg, &val); - if (ret =3D=3D -EBUSY) - continue; - else + if (ret !=3D -EBUSY) break; } -- 2.31.1