[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: AW: [PATCH] soc: aspeed: fix a ternary sign expansion bug
From:       Sergey Organov <sorganov () gmail ! com>
Date:       2021-04-23 14:40:19
Message-ID: 878s59rrn0.fsf () osv ! gnss ! ru
[Download RAW message or body]

Walter Harms <wharms@bfs.de> writes:

> as indepentent observer,
> i would go for Dans solution:
>
> ret = kfifo_to_user();
> /* if an error occurs just return */
> if (ret)
>    return ret;
>
> /* otherwise return the copied number of bytes */
>
> return copied;
>
> there is no need for any deeper language knowledge,

Yep, but this is not idiomatic C, so one looking at this code would
tend to convert it back to ternary, and the actual problem here is that
the type of 'copied' does not match the return type of the function.

-- Sergey Organov
[prev in list] [next in list] [prev in thread] [next in thread]