[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] openrisc: use device tree to determine present cpus
From:       Stafford Horne <shorne () gmail ! com>
Date:       2021-01-31 21:27:52
Message-ID: 20210131212752.GG2002709 () lianli ! shorne-pla ! net
[Download RAW message or body]

On Sun, Jan 31, 2021 at 09:22:31AM +0100, Jan Henrik Weinstock wrote:
> On 31/01/2021 00:03, Stafford Horne wrote:
> 
> > This looks good, one small comment below.  Can you send the next patch as a v2?
> > 
> > Using 'git format-patch -v2 ...'
> 
> Sorry, was not aware of that, will do better next time!
> 
> > Should we warn on the else case?
> 
> I think it is fine for the kernel to have room for more CPUs than are
> actually present (i.e. NR_CPUs > present_cpus is OK). Other Archs do not
> show a warning in this case either, therefore I also omitted it.

Fair enough.

Reviewed-by: Stafford Horne <shorne@gmail.com>

I can queue this for 5.12 when you send v2.

-Stafford
[prev in list] [next in list] [prev in thread] [next in thread]