[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH v1] mmc: dt: add DT bindings for ls1028a eSDHC host controller
From:       Li Yang <leoyang.li () nxp ! com>
Date:       2019-04-30 23:12:05
Message-ID: CADRPPNQ4RYhe5n_ZA_xrhG8VARsvV3cwVgnuinedb2VHKkDzbQ () mail ! gmail ! com
[Download RAW message or body]

On Tue, Apr 30, 2019 at 12:16 AM Yinbo Zhu <yinbo.zhu@nxp.com> wrote:
>
> From: Yinbo Zhu <yinbo.zhu@nxp.com>

The patch title better to be "dt-bindings: mmc: ..."
>
> Add "fsl,ls1028a-esdhc" bindings for ls1028a eSDHC host controller
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
>  .../devicetree/bindings/mmc/fsl-esdhc.txt          |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> index 99c5cf8..a7250b9 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> +++ b/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt
> @@ -21,6 +21,7 @@ Required properties:
>         "fsl,ls1043a-esdhc"
>         "fsl,ls1046a-esdhc"
>         "fsl,ls2080a-esdhc"
> +       "fsl,ls1028a-esdhc"

Better to be alphabetical order.

>    - clock-frequency : specifies eSDHC base clock frequency.
>
>  Optional properties:
> --
> 1.7.1
>
[prev in list] [next in list] [prev in thread] [next in thread]