[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path
From: Tejun Heo <tj () kernel ! org>
Date: 2015-11-30 22:53:18
Message-ID: 20151130225318.GD9039 () mtj ! duckdns ! org
[Download RAW message or body]
Hello, Serge.
On Mon, Nov 30, 2015 at 12:37:58PM -0600, Serge E. Hallyn wrote:
> > Yeah, I agree but the name is kinda misleading tho. The output isn't
> > really a relative path but rather absolute path against the specified
> > root. Maybe updating the function and parameter names would be
> > helpful?
> >
>
> Ok - updating the comment is simple enough. Though the name/params
> kernfs_path_from_node_locked(from, to) still seem to make sense. Would
> you prefer something like kernfs_absolute_path_from node_locked()? I
> hesitate to call 'from' 'root' since kernfs_root is a thing and this
> is not that.
Hmmm... I see. Let's just make sure that the comment is clear about
the fact that it calculates (pseudo) absolute path rather than
relative path.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic