[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [PATCH v2 1/4] ozwpan: Use proper check to prevent heap overflow
From: Dan Carpenter <dan.carpenter () oracle ! com>
Date: 2015-05-26 13:32:21
Message-ID: 20150526133221.GG11588 () mwanda
[Download RAW message or body]
On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
> + data_len = elt->length -
> sizeof(struct oz_get_desc_rsp) + 1;
This was in the original code, but I wonder where the + 1 comes from.
Does anyone know?
To be honest, I would prefer if we just checked:
if (elt->length < sizeof(struct oz_get_desc_rsp) + 1)
return;
data_len = elt->length - sizeof(struct oz_get_desc_rsp) + 1;
Shouldn't there be an upper bound on length? Shigekatsu?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic