[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH 6/11] net: wireless: Remove useless return variables
From:       Dan Carpenter <dan.carpenter () oracle ! com>
Date:       2014-05-31 20:23:51
Message-ID: 20140531202351.GN15585 () mwanda
[Download RAW message or body]

On Sat, May 31, 2014 at 10:14:06AM -0300, Peter Senna Tschudin wrote:
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
> index b0fd807..57ecc05 100644
> --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
> +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
> @@ -1538,11 +1538,7 @@ static s8
>  wlc_user_txpwr_antport_to_rfport(struct brcms_phy *pi, uint chan, u32 band,
>  				 u8 rate)
>  {
> -	s8 offset = 0;
> -
> -	if (!pi->user_txpwr_at_rfport)
> -		return offset;
> -	return offset;
> +	return 0;
>  }

The original code looks buggy.  I wonder what it was supposed to do?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]