[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH v2] Bluetooth: Add hci_h4p driver
From:       Marcel Holtmann <marcel () holtmann ! org>
Date:       2013-12-31 23:23:36
Message-ID: E7C15C38-8E0E-4D49-9E93-5E3DAF77E252 () holtmann ! org
[Download RAW message or body]

Hi Pavel,

> > > +static struct task_struct *h4p_thread;
> > 
> > Can’t this be done using a work queue. You are looking at a 3.14
> > kernel the earliest. We have way better primitives these days.
> 
> I tried to convert it to work queue, but was not too
> succesfull. Workqueue is not really good match for what this is trying
> to do... Nokia code relies on sleeping, than timing those sleeps for
> signaling. I'm still trying to wrap my head around it.
> 
> Ok, I guess I could convert it to one big workqueue task, and leave
> the logic alone. Was that what you wanted?

the Bluetooth subsystem moved away from tasklets and uses workqueues for everything. So this should be \
just fine for this driver as well. I do not know about what timings are required, but they should only \
matter during initial device setup. The HCI traffic is actually driven by the Bluetooth core.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[prev in list] [next in list] [prev in thread] [next in thread]