[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH 4/4] async: replace list of active domains with global list of pending items
From:       James Hogan <james () albanarts ! com>
Date:       2013-01-25 10:10:44
Message-ID: CAAG0J9_rUq1c-UFy1mVssqpognLUuCGsq1sDOLK+z8ue6A-ZqQ () mail ! gmail ! com
[Download RAW message or body]

On 25 January 2013 10:08, James Hogan <james@albanarts.com> wrote:
> On 25 January 2013 01:01, Tejun Heo <tj@kernel.org> wrote:
>> Hello,
>>
>> On Fri, Jan 25, 2013 at 12:13:45AM +0000, James Hogan wrote:
>>> Should it have this?
>>> +     else
>>> +             INIT_LIST_HEAD(&entry->global_list)
>>
>> I think it would be better to have INIT_LIST_HEAD() during @entry
>> initialization.  Heh, I forgot that.  I wonder why it didn't crash on
>> my machine.  Can you please cook up a patch to init both list fields
>> right after kzalloc()?
>
> How does the following patch look? Feel free to squash it into the
> original to avoid breaking bisection :).

Sorry, gmail has screwed with the patch. I'll send separately.

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]