[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH][RESEND] do not redefine userspace's NULL #define
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2012-04-14 8:54:23
Message-ID: 201204141054.23935.l.lunak () suse ! cz
[Download RAW message or body]

On Saturday 14 of April 2012, Linus Torvalds wrote:
> On Sat, Apr 14, 2012 at 1:21 AM, Lubos Lunak <l.lunak@suse.cz> wrote:
> >  How about the patch? Are there any *actual* problems with it or can it
> > please go in?
>
> If we're going to change that thing, I'd actually prefer to just move
> it inside the #ifdef __KERNEL__ entirely, and get rid of the cplusplus
> case.
>
> IOW, something like this (obviously white-space-mangled) patch:
...
> which protects the kernel NULL definition along with the whole
> offsetof and true/false ones too. And just gets rid of the insane C++
> case entirely.

 That's what the original version of my patch did, but Arnd pointed out that 
other exported headers might use NULL and thus not be self-contained in 
userspace after this change, breaking backwards source compatibility. But I'd 
expect such breakages to be rather unlikely (stddef.h is probably pulled in 
by pretty much everything), so if you're fine with it, I'm ok with this 
solution too.

-- 
 Lubos Lunak
 l.lunak@suse.cz

["forwarded message" (message/rfc822)]

Subject: [PATCH] do not export kernel's NULL #define to userspace
From: Lubos Lunak <l.lunak@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
 linux-kernel@vger.kernel.org
Date: Wed, 21 Mar 2012 14:08:24 +0100
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <201203211408.25040.l.lunak@suse.cz>
X-Length: 1543
X-UID: 26267

GCC's NULL is actually __null, which allows detecting some questionable
NULL usage and warn about it. Moreover each platform/compiler should have
its own stddef.h anyway (which is different from linux/stddef.h).
So there's no good reason to leak kernel's NULL to userspace and
override what the compiler provides.

Signed-off-by: Luboš Luňák <l.lunak@suse.cz>
---
 include/linux/stddef.h |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/linux/stddef.h b/include/linux/stddef.h
index 6a40c76..1747b67 100644
--- a/include/linux/stddef.h
+++ b/include/linux/stddef.h
@@ -3,14 +3,10 @@
 
 #include <linux/compiler.h>
 
+#ifdef __KERNEL__
+
 #undef NULL
-#if defined(__cplusplus)
-#define NULL 0
-#else
 #define NULL ((void *)0)
-#endif
-
-#ifdef __KERNEL__
 
 enum {
 	false	= 0,
-- 
1.7.3.4
-- 
 Lubos Lunak
 l.lunak@suse.cz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]