[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [PATCH] cb710: fix #ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
From: James Hogan <james () albanarts ! com>
Date: 2011-06-21 16:40:53
Message-ID: BANLkTik7CqKJUGNbvTO-WbfzVR2MxT=j3A () mail ! gmail ! com
[Download RAW message or body]
Hi,
2011/6/21 Chris Ball <cjb@laptop.org>:
> Hi,
>
> On Tue, Jun 21 2011, Michał Mirosław wrote:
>> On Tue, Jun 21, 2011 at 10:55:34AM +0100, James Hogan wrote:
>>> HAVE_EFFICIENT_UNALIGNED_ACCESS is a config option, therefore it needs
>>> the CONFIG_ before it when used by the preprocessor.
>>>
>>> Signed-off-by: James Hogan <james@albanarts.com>
>>> ---
>>> drivers/misc/cb710/sgbuf2.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/misc/cb710/sgbuf2.c b/drivers/misc/cb710/sgbuf2.c
>>> index d019746..2a40d0e 100644
>>> --- a/drivers/misc/cb710/sgbuf2.c
>>> +++ b/drivers/misc/cb710/sgbuf2.c
>>> @@ -47,7 +47,7 @@ static uint32_t sg_dwiter_read_buffer(struct
>>> sg_mapping_iter *miter)
>>>
>>> static inline bool needs_unaligned_copy(const void *ptr)
>>> {
>>> -#ifdef HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> return false;
>>> #else
>>> return ((ptr - NULL) & 3) != 0;
>>
>> Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> Thanks, pushed to mmc-next for 3.0.
>
> (James, your patch was corrupt due to a hard line break on the @@
> line -- please fix that next time around.)
Ahh, sorry about that Chris, I thought I had that problem sorted!
Thanks
James
>
> - Chris.
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
>
--
James Hogan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic