[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [PATCH 09/10] mm/slab.c: Fix continuation line formats
From: Frans Pop <elendil () planet ! nl>
Date: 2010-01-31 23:53:44
Message-ID: 201002010053.45818.elendil () planet ! nl
[Download RAW message or body]
On Sunday 31 January 2010, Joe Perches wrote:
> On Sun, 2010-01-31 at 21:32 +0100, Frans Pop wrote:
> > If that spacing part is really needed (is it?), wouldn't it be more
> >
> > readable as:
> > > + seq_printf(m, " : globalstat %7lu %6lu %5lu %4lu"
> > > + " "
> > > + "%4lu %4lu %4lu %4lu %4lu",
> > > + allocs, high, grown,
>
> If it's required (most likely not, but it's a seq_printf and
> some people think those should never be modified because it's
> a public interface), it should probably be explicit:
>
> " : globalstat %7lu %6lu %5lu %4lu \t\t\t\t%4lu %4lu %4lu %4lu %4lu"
Yes, would be better. And if it is kept for compatibility it probably
deserves a comment explaining the weirdness.
Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic