[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [PATCH] driver-core: devtmpfs - driver core maintained /dev
From: Andrew Morton <akpm () linux-foundation ! org>
Date: 2009-05-01 22:21:33
Message-ID: 20090501152133.e3f5038c.akpm () linux-foundation ! org
[Download RAW message or body]
On Fri, 1 May 2009 23:59:32 +0200
Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Fri, May 1, 2009 at 21:26, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Fri, 1 May 2009 13:16:22 +0200
> > Kay Sievers <kay.sievers@vrfy.org> wrote:
> >
> >> On Fri, May 1, 2009 at 07:29, Andrew Morton <akpm@linux-foundation.org> wrote:
> >>
> >> > dev->type->nodename() might have failed due to -ENOMEM, in which case
> >> > it seems wrong to assume that it returned NULL for <whatever reason you
> >> > thought it might want to return NULL>.
> >> >
> >> > It's all a bit confused.
> >>
> >> This logic is only for providing a custom name hint. Only a few
> >> devices need that at all. If the allocation fails, the default name
> >> will be used, not the custom name.
> >
> > But that's bad, isn't it? __It means that the kernel will come up with
> > one name if the memory allocation succeeded, and a different name if
> > the allocation failed.
>
> Yeah, sure, it's bad. But I think we have pretty much lost anyway, if
> we run into oom at this stage.
>
> What should we do instead? If we, for some reason, can not get a
> possible custom name?
Not much - just sayin'.
Presumably the page allocator will have given a big spew, so the
operator knows what went wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic