[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: ftrace behaviour (was: [PATCH] ftrace: introduce
From:       Pekka Paalanen <pq () iki ! fi>
Date:       2008-12-31 22:08:12
Message-ID: 20090101000812.1fd2c088 () iki ! fi
[Download RAW message or body]

On Wed, 31 Dec 2008 14:06:26 -0500 (EST)
Steven Rostedt <rostedt@goodmis.org> wrote:

> I was thinking of only changing the debugfs file.
> 
> > Are we controlling an action (recording events), a feature (a buffer
> > where to record) or an implementation (a ring buffer)?
> 
> Good point. It only disables the recording, so perhaps a "record_enabled" 
> would be better?

To me "record" sounds more of a noun than a verb, but it's both and
I'm not a native speaker. Still, it brings me to "recording_enabled",
and do we really need the "_enabled" part? So we end up to what I
suggested earlier: "recording" with values 0 and 1. :-)

Anyway, it's good to start the file name with a few distinct letters,
it makes tab-completion so much easier on the command line.

> > What does the user actually want to control? A buffer? A ring
> > buffer? Recording stuff? The tracer? Tracing? Data flow?
> > Assuming there are also other users than tracing, does it make
> > sense to control the ring buffer facility itself?
> 
> I think the name record_enabled for debugfs is the best. This is exactly 
> what happens (not how it is implemented). When someone echos 0 to 
> record_enabled (currently called tracing_on), it stops the recording, and 
> nothing else. The tracers still try to write to the buffer, but the write 
> always fails. This does not disable the tracers or even notify the tracer 
> that the buffers have stopped recording. This is just a simple light 
> weight way to stop and start recording to the trace buffers from either 
> user space or kernel space.  Kernel space can stop it, and user space can 
> start it again (that was the original request for this feature).
> 
> I'm leaning towards record_enabled now.

-- 
Pekka Paalanen
http://www.iki.fi/pq/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]