[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] driver core: Use 'ret' variable in
From:       Jason Baron <jbaron () redhat ! com>
Date:       2008-10-31 20:40:24
Message-ID: 20081031204024.GB3109 () redhat ! com
[Download RAW message or body]

On Thu, Oct 30, 2008 at 10:44:39PM +0100, Johann Felix Soden wrote:
> From: Johann Felix Soden <johfel@users.sourceforge.net>
> 
> The 'ret' variable is assigned, but not used in the return statement. Fix this.
> 
> Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
> CC: Jason Baron <jbaron@redhat.com>
> ---
>  lib/dynamic_printk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/dynamic_printk.c b/lib/dynamic_printk.c
> index d83660f..d0fd0e4 100644
> --- a/lib/dynamic_printk.c
> +++ b/lib/dynamic_printk.c
> @@ -135,7 +135,7 @@ int unregister_dynamic_debug_module(char *mod_name)
>  	nr_entries--;
>  out:
>  	up(&debug_list_mutex);
> -	return 0;
> +	return ret;
>  }
>  EXPORT_SYMBOL_GPL(unregister_dynamic_debug_module);
>  

looks good to me.

Acked-by: Jason Baron <jbaron@redhat.com>

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]