[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH 17/39] clobber rbx in putuser_64.S
From:       Andi Kleen <andi () firstfloor ! org>
Date:       2008-06-30 23:45:04
Message-ID: 20080630234504.GA3029 () one ! firstfloor ! org
[Download RAW message or body]

> But for this case, I think we can come up with a macro that selects the 
> appropriate register for each of them. Should be easy to do now that the 
> code is merged.

Note that each get_user() backend is ~10 lines or so. If you add
that many macros you might end up with more code than if you 
just keep them separate.

While I admit I am also partly to blame for some asm macro
mess, e.g. in entry.S, I relented and would now advocate
to minimize macro use in assembler. It simply makes it much
harder to understand and to change.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]