[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: patch
From:       Greg KH <greg () kroah ! com>
Date:       2008-04-29 15:22:49
Message-ID: 20080429152249.GB11329 () kroah ! com
[Download RAW message or body]

On Tue, Apr 29, 2008 at 12:48:11AM -0700, SL Baur wrote:
> On 4/28/08, gregkh@suse.de <gregkh@suse.de> wrote:
> >
> >  This is a note to let you know that I've just added the patch titled
> >
> >      Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor
> >
> >  to my gregkh-2.6 tree.  Its filename is
> >
> >      sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch
> 
> >  +       char devt_str[15];
> >  +
> >  +       if (kobj) {
> >  +               format_dev_t(devt_str, dev->devt);
> 
> This part is ugly, but is not the fault of the patch.  The ill-
> considered interface for `format_dev_t' is something that probably
> noone wants to fix.

Why not?  Patches are always welcome, it's not like that function is
used in that many different places, should be a simple change...

> Otherwise, still OK with me.
> 
> Reviewed-by: SL Baur <steve@xemacs.org>
> 
> (Is Reviewed-by not sticky?)

Yes, it is, I'll add it to my version of the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]