[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH -rt] fix setting of preempt_max_latency and preempt_thresh on 64 bit systems
From:       Andreas Mohr <andi () rhlx01 ! fht-esslingen ! de>
Date:       2007-03-27 19:15:42
Message-ID: 20070327191542.GA15514 () rhlx01 ! hs-esslingen ! de
[Download RAW message or body]

Hi,

On Tue, Mar 27, 2007 at 01:19:07PM -0400, Steven Rostedt wrote:
> Ingo,
> 
> I wasn't able to turn on latency tracing on a x86_64 box. Using logdev
> to see what was happening, I found that echoing 0
> into /proc/sys/kernel/preempt_max_latency would only change the max from
> -1ULL to 0xffffffff00000000. Which would keep the max pretty high still.
> 
> The problem is in sysctl.c where preempt_max_latency can be modified. On
> systems where cycle_t is greater than the size of int (x86_64) we only
> write to the 4 LSB.

Maybe fix up all the other myriads of sysctl entries which use a rather
non-precise generic sizeof(int) as well?
Or doesn't that make sense?
Maybe this is because it's security relevant and you'd better make sure
to know *exactly* the number of integers a buffer's length is supposed to be?

Thanks,

Andreas Mohr
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]