[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
From:       Jeremy Fitzhardinge <jeremy () goop ! org>
Date:       2006-08-31 21:39:40
Message-ID: 44F7571C.70806 () goop ! org
[Download RAW message or body]

Ian Campbell wrote:
> Are you sure that works? When I tried it didn't. I think because
> asm/smp.h isn't included by linux/smp.h for !SMP.
>   

Nah, testing is overrated.

> I needed the below to make it work, but including linux/smp.h and
> asm/smp.h in the same file smells a bit fishy to me... Probably
> acceptable for now if you are thinking of redoing SMP processor bringup
> anyway.
>   

That looks OK for now.  Rearranging CPU bringup looks a little bit 
complex to do immediately, so this seems like a reasonable fix for now.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]