[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] XFS: remove pointless conditional testing 'nmp' vs NULL in fs/xfs/xfs_rtalloc.c::xfs_gro
From:       Nathan Scott <nathans () sgi ! com>
Date:       2006-08-17 6:31:10
Message-ID: 20060817163109.A2792453 () wobbly ! melbourne ! sgi ! com
[Download RAW message or body]

On Wed, Aug 16, 2006 at 10:44:19PM +0200, Jesper Juhl wrote:
> On Monday 14 August 2006 09:25, Jesper Juhl wrote:
> > On 14/08/06, Nathan Scott <nathans@sgi.com> wrote:
> > > On Sun, Aug 13, 2006 at 12:16:50AM +0200, Jesper Juhl wrote:
> > >
> > > > This patch gets rid of the pointless check.
> > >
> > > Hmm, seems like code churn that makes the code slightly less
> > > obvious, but thats just me... I'd prefer a tested patch that
> > > implements the above suggestion, to be honest. :)
> > >
> > Ok, I'll see what I can come up with.
> > 
> 
> How this?
> 
> Compile tested only since I'm at home and don't have any XFS filesystems to
> play with atm.

It looks good.  I've tested it, and it works fine - I'll merge it
into my tree shortly.  Thanks for following up on this.

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]