[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-kernel
Subject: Re: [ck] Re: [PATCH] vm - swap_prefetch-15
From: Gustavo Barbieri <barbieri () gmail ! com>
Date: 2005-10-07 14:44:00
Message-ID: 9ef20ef30510070744l7ff1f1bbweb4da1ceb513f246 () mail ! gmail ! com
[Download RAW message or body]
On 10/7/05, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> Hi,
>
> On 10/7/05, Con Kolivas <kernel@kolivas.org> wrote:
> > Good point, thanks! Any and all feedback is appreciated.
>
> Well, since you asked :-)
>
> > +/*
> > + * How many pages to prefetch at a time. We prefetch SWAP_CLUSTER_MAX *
> > + * swap_prefetch per PREFETCH_INTERVAL, but prefetch ten times as much at a
> > + * time in laptop_mode to minimise the time we keep the disk spinning.
> > + */
> > +#define PREFETCH_PAGES() (SWAP_CLUSTER_MAX * swap_prefetch * \
> > + (1 + 9 * laptop_mode))
>
> This looks strange. Please either drop the parenthesis from PREFETCH_PAGES or
> make it a real static inline function.
Or make it a "const static" variable, so compiler will check types and
everything, but the symbol will not be present in the binary, causing
no overhead. So it could be:
const unsigned PREFETCH_PAGES = (SWAP_CLUSTER_MAX * swap_prefetch * \
(1 + 9 * laptop_mode));
--
Gustavo Sverzut Barbieri
---------------------------------------
Computer Engineer 2001 - UNICAMP
GPSL - Grupo Pro Software Livre
Cell..: +55 (19) 9165 8010
Jabber: gsbarbieri@jabber.org
ICQ#: 17249123
MSN: barbieri@gmail.com
Skype: gsbarbieri
GPG: 0xB640E1A2 @ wwwkeys.pgp.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic