[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: 2.4.30 xfs bug
From:       Christoph Hellwig <hch () infradead ! org>
Date:       2005-05-18 14:09:58
Message-ID: 20050518140958.GA22771 () infradead ! org
[Download RAW message or body]

On Thu, May 12, 2005 at 11:17:01AM -0700, Russell Miller wrote:
> 2.4.30 will not compile if XFS is turned on, but XFS debugging is not.  
> Culprit is:
> 
> fs/xfs/linux-2.4/xfs_buf.c line 1076.  Apparently pagebuf_lock_value is used 
> somewhere else, even if it's not defined because debugging is off.

Looks like a trivial one-liner got lost when merging from the SGI CVS tree.

Macelo, can you apply this little patch below?


--- 1.195/fs/xfs/linux-2.4/xfs_buf.c	2005-01-12 01:08:23 +01:00
+++ edited/fs/xfs/linux-2.4/xfs_buf.c	2005-05-18 16:06:09 +02:00
@@ -1073,7 +1073,7 @@ pagebuf_cond_lock(			/* lock buffer, if 
 	return(locked ? 0 : -EBUSY);
 }
 
-#ifdef DEBUG
+#if defined(DEBUG) || defined(XFS_BLI_TRACE)
 /*
  *	pagebuf_lock_value
  *
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]