From linux-kernel Thu Feb 17 17:14:04 2005 From: Jesse Barnes Date: Thu, 17 Feb 2005 17:14:04 +0000 To: linux-kernel Subject: Re: pci_map_rom bug? Message-Id: <200502170914.04305.jbarnes () sgi ! com> X-MARC-Message: https://marc.info/?l=linux-kernel&m=110866072127071 On Thursday, February 17, 2005 8:29 am, Jon Smirl wrote: > On Wed, 16 Feb 2005 16:00:47 -0800, Jesse Barnes wrote: > > It looks like it's trying to verify all the ROMs on a given PCI device > > rather than just the one we just ioremap'd above. Should this check just > > be inline and the loop deleted? In that case, all of the breaks would > > turn into return NULLs (though the code should probably be refactored to > > make that a little clearer) along with an iounmap? > > The ROM experts on linux-pci supplied that code. It is legal to have > multiple images in a ROM for different formats, x86, OpenFirmware, > proprietary. The loop is adding all of the images together. Above we > IO remapped the entire PCI window which may be 64K and it contained > two images each at 20K. The extra loop returns the smaller size. This > lets the copy_rom case allocate 40K of memory instead of 64K. Ah, ok, but we still have the situation that cause me to post the cleanup patch in the first place--pci_map_rom succeeds, but the first two bytes aren't 0x55aa but 0x0303... Any ideas? Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/