[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: RFC: [2.6 patch] ieee1394 cleanup
From:       Adrian Bunk <bunk () stusta ! de>
Date:       2004-10-31 23:29:54
Message-ID: 20041031232954.GG2495 () stusta ! de
[Download RAW message or body]

On Sun, Oct 31, 2004 at 04:28:58PM -0500, Ben Collins wrote:

> Need to leave the csr1212 files alone. csr1212.[ch] is used for userspace
> and kernelspace, and I don't want to have two versions.

But in this case, these functions don't have to be EXPORT_SYMBOL'ed?

And besides this, they are global functions meaning that although they 
are never used inside the kernel, they need space for every user of 
FireWire.

What about wrapping them inside #ifndef __KERNEL__ ?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]