[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: net: generic netdev_ioaddr
From:       Krzysztof Halasa <khc () pm ! waw ! pl>
Date:       2004-10-31 23:14:24
Message-ID: m3wtx6jx9r.fsf () defiant ! pm ! waw ! pl
[Download RAW message or body]

Hi,

Pekka Enberg <penberg@cs.helsinki.fi> writes:

> Cops already exposes base address and irq as module parameters and yet
> it calls netdev_boot_setup_check() to check "netdev=" so I assume
> there's a reason for that.  Perhaps something like the (untested) patch
> below would make more sense?

IMHO partially: base_addr etc should go from the core (to driver's
local structs if needed). I think no general netdev-setup thing is
needed, we have module parameters and library functions.

No ioctl for such things is needed either.
/sbin/ifconfig shouldn't mess with hardware data such as I/O address,
IRQ etc. - it should be a configuration tool for software protocols,
not for hardware (i.e. as /sbin/ip is).

My opinion of course.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]