[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: Patch?: linux-2.5.29-ide109 small bio-based cleanup
From:       Marcin Dalecki <dalecki () evision ! ag>
Date:       2002-07-31 20:34:43
[Download RAW message or body]

Adam J. Richter wrote:
> 	linux-2.5.29/drivers/ide/pcidma.c has a bunch of code in
> udma_new_table to work around transfers that cross 64kB boundaries
> and transfers that are exactly 64kB when the IDE chipset might only
> be able to handle transfers of *less than* 64kB.  However, the current
> bio code already has limits that you can set to tell it never to send
> IO requests with those problems (blk_queue_segement_boundary and
> blk_queue_max_segment_size).
> 
> 	The following patch makes the IDE code use the bio facilities
> to set these limits, and deletes the code that was needed to work
> around these cases.  This shrinks the code by a net of 29 lines,
> and may allow for a tiny bit of space savings in the future,
> now that we know that none of the scatterlist entries that
> pci_map_sg returns will have to be split. 
> 
> 	I also got rid of an unnecessary variable and some
> extra data clearing and copying in init_hw_data.
> 
> 	I am running this code now on the main that I'm using
> to compose this email.

Thanks! Great! Code immediately swallowed, since obviously correct :-).
However I will drop the CONFIG_CHIPSET outdefs, since at some
point in time we will make *every* host chip controller code
loadable at runtime.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
[prev in list] [next in list] [prev in thread] [next in thread]