[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] don't reset alarm interrupt on RTC
From:       Tim Hockin <thockin () sun ! com>
Date:       2001-10-31 22:34:57
[Download RAW message or body]

Patrick Mochel wrote:

> -       tmp &=  ~RTC_AIE;
> +       //tmp &=  ~RTC_AIE;
>         tmp &=  ~RTC_UIE;
>         CMOS_WRITE(tmp, RTC_CONTROL);
>         CMOS_READ(RTC_INTR_FLAGS);
 
> Why would you want to unconditionally enable this interrupt?

We don't unconditionally set it, we just leave it enabled (the code was
uncoditionally UNsetting it).  There are ioctl()s to set/unset PIE, AIE,
UIE.

> And how do you set the alarm time?

ioctl(fd, RTC_ALM_SET);
 
> But, I don't think this should be enabled by default.

if anything, our patch is not correct ENOUGH.  none of AIE, PIE, or UIE,
should be molested by rtc_release().

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[prev in list] [next in list] [prev in thread] [next in thread]